search

PSLmodels / Tax-Calculator

USA Federal Individual Income and Payroll Tax Microsimulation Model
https://taxcalc.pslmodels.org
Other
255 stars 154 forks source link

consider odc in iitax calculation #2704

Closed bodiyang closed 10 months ago

bodiyang commented 10 months ago

This PR address the issue that other dependent credit should be taken into consideration in the iitax calculation.

For the year 2021, child tax credit and other dependent credit are categorized as refundable tax credit. iitax should reflect this change for the year 2021 (note: only for the year 2021, all other years ctc and odc are nonrefundable).

codecov[bot] commented 10 months ago

Codecov Report

Merging #2704 (4d167a1) into master (4c54366) will not change coverage. Report is 2 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2704/graphs/tree.svg?width=650&height=150&src=pr&token=KqtTvRSNjQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) ```diff @@ Coverage Diff @@ ## master #2704 +/- ## ======================================= Coverage 98.54% 98.54% ======================================= Files 14 14 Lines 2609 2609 ======================================= Hits 2571 2571 Misses 38 38 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `98.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more.
bodiyang commented 10 months ago

@jdebacker all tests pass locally; online test experiencing the codecov issue again. Can you have a rerun see if we can pass?

jdebacker commented 10 months ago

@bodiyang Thanks for this PR! Nice addition of a new parameter to handle 2021 law.

I have some suggestions on how you handle the cases in calcfunctions.IITAX. But other than that, this PR looks good to me.

bodiyang commented 10 months ago

@jdebacker Thanks for the review. All tests pass locally and on git action. Please check if the PR is ready to merge

jdebacker commented 10 months ago

Great - thank you @bodiyang! Merging.