Closed jdebacker closed 9 months ago
Merging #2707 (bf6332a) into master (6798fba) will not change coverage. Report is 1 commits behind head on master. The diff coverage is
n/a
.
@MattHJensen This PR is ready for your review. Thanks!
@jdebacker, do you think we should protect puf and cps users from setting this parameter outside of the ranges supported by their data? Or say this param isn't compatible with those data?
@MattHJensen Good point about data limitations affecting this parameter's usefulness. To address this concern, I've added a note about this in the "notes" metadata field for the capital_loss_limitation
parameter.
Note that I am reluctant to set "puf": false
in the compatible_data
field because the parameter will work with the PUF as expected, so long as the values is less than or equal to the current law value (as the PUF does not provide information on capital losses beyond the current law limit).
Do you think this is satisfactory?
@MattHJensen I think this PR is ready to merge. Let me know if you have further thoughts. Will merge if I don't hear back in about 24hrs. Thanks!
This PR addresses Issue #2632 by parameterizing the capital loss limitation.