Closed martinholmer closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f850d81
) 98.54% compared to head (d806ac3
) 98.54%. Report is 1 commits behind head on master.
@martinholmer Thanks for making this change.
Can you write a unit test that covers the taxcalcio.analyze
function with the new outputs? With that, I think this PR will be ready to merge.
@jdebacker, Why am I now getting the following error?
What is the failing test meant to do: Test reading JSON assumption file using URL.
@jdebacker, Can you merge #2714? This PR did pass all the tests on ubuntu,3.9.
Thanks @martinholmer. Merging.
In prior versions of the Tax-Calculator CLI tool,
tc
, the--sqldb
option created an SQLite3 database that contained variables for the specified reform, but not variables for the baseline. This made it more difficult for users to conduct analysis of policy reforms using SQL scripts.This pull request enhances the
tc
tool so that the--sqldb
option generates an SQLite3 database that contains two tables (each containing the same set of specified variables), one for the baseline and one for the reform.