PSLmodels / Tax-Calculator

USA Federal Individual Income and Payroll Tax Microsimulation Model
https://taxcalc.pslmodels.org
Other
254 stars 153 forks source link

Correct a few historical income tax bracket parameter values #2730

Closed martinholmer closed 5 months ago

martinholmer commented 5 months ago

A year or two ago, there were a few mistakes made in entering by hand the values of some II_brk? and PT_brk? amounts. This pull request fixes those incorrect tax parameter values. It also fixes the reforms/rounding2022.json reform used in the round-trip-reform test so that the round-trip-reform test does not fail. Also, the expected aggregate test results for 2020 and 2021 changed slightly given the correction in the tax bracket values.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.42%. Comparing base (ec0a4ef) to head (d9aab06). Report is 1 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2730/graphs/tree.svg?width=650&height=150&src=pr&token=KqtTvRSNjQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) ```diff @@ Coverage Diff @@ ## master #2730 +/- ## ======================================= Coverage 99.42% 99.42% ======================================= Files 13 13 Lines 2593 2593 ======================================= Hits 2578 2578 Misses 15 15 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2730/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `99.42% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more.
jdebacker commented 5 months ago

@martinholmer Thanks for this update. I was surprise to see how off some of those values were. From some spot checking, I found no errors in your updated values. Merging.