search

PSLmodels / Tax-Calculator

USA Federal Individual Income and Payroll Tax Microsimulation Model
https://taxcalc.pslmodels.org
Other
254 stars 153 forks source link

testing files change for V4 #2752

Closed bodiyang closed 2 months ago

bodiyang commented 3 months ago

This PR is part of the effort to merge V4_development branch into master branch.

V4_development GitActions tests fail, on a single test to compare a local reform file and an online url file.

This PR makes necessary changes (changing the online url file) to help V4_development branch pass its online tests.

This PR will make V4_development branch pass all GitActions tests (but will make the master branch fail its online tests, for now). Our final goal is to merge V4_development branch into master branch. After the merge, master branch will have all tests pass.

bodiyang commented 3 months ago

@jdebacker after merge this PR, the V4_development branch tests are expected to pass

martinholmer commented 3 months ago

I don't understand what this is doing. @bodiyang, please resolve your test failures on you local computer.

jdebacker commented 3 months ago

@bodiyang Can you provide a more detailed description in the first comment in this thread?

@martinholmer We are preparing for a version 4.0 release. In the v4_development branch, only a single test fails and that is one that runs a test on a reform read from a URL (test_policy.py::test_json_reform_url). @bodiyang is modifying the reform called by that test in this PR (which will be merged with checks failing - they fail because the master branch does not have separate employer and employee side payroll tax parameters as the v4_development branch does). Once these changes are merged into master, we can open a PR merging v4_development -> master and all checks will pass.

martinholmer commented 3 months ago

@jdebacker said:

We are preparing for a version 4.0 release. In the v4_development branch, only a single test fails and that is one that runs a test on a reform read from a URL (test_policy.py::test_json_reform_url). @bodiyang is modifying the reform called by that test in this PR (which will be merged with checks failing - they fail because the master branch does not have separate employer and employee side payroll tax parameters as the v4_development branch does). Once these changes are merged into master, we can open a PR merging v4_development -> master and all checks will pass.

Why was there no explanation of this in the P|R?

bodiyang commented 3 months ago

@martinholmer Please see my first comment for the goal of this PR.

@jdebacker I think this PR is ready to merge, which will help V4_development branch have all tests pass.

jdebacker commented 2 months ago

Thanks for these changes, @bodiyang. Merging.