search

PSLmodels / Tax-Calculator

USA Federal Individual Income and Payroll Tax Microsimulation Model
https://taxcalc.pslmodels.org
Other
254 stars 153 forks source link

4.0.0 release #2753

Closed bodiyang closed 2 months ago

bodiyang commented 3 months ago

This PR prepares Tax-Calc 4.0.0 new version release.

please check release.md file for the new features of the model.

martinholmer commented 3 months ago

@bodiyang, I don't understand why you have submitted PR #2753 when tests are failing. Please, revise you code so that ALL tests pass on you local computer. Then submit the PR.

jdebacker commented 3 months ago

@martinholmer, please see PR #2753 to better understand what is going on.

@bodiyang Can you make this a draft PR until #2573 is merged?

martinholmer commented 3 months ago

@jdebacker said:

PR https://github.com/PSLmodels/Tax-Calculator/pull/2753 to better understand what is going on.

There was absolutely no explanation of "what is going on" in that original PR.

jdebacker commented 2 months ago

@bodiyang This branch appears to be just a few changes from master (version numbers, release notes). Can you merge the latest v4_development branch into your 4.0.0-release branch?

bodiyang commented 2 months ago

@bodiyang This branch appears to be just a few changes from master (version numbers, release notes). Can you merge the latest v4_development branch into your 4.0.0-release branch?

have merge the change from v4_development into 4.0.0-release

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.42%. Comparing base (e0234b6) to head (cb7b95a). Report is 16 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753/graphs/tree.svg?width=650&height=150&src=pr&token=KqtTvRSNjQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) ```diff @@ Coverage Diff @@ ## master #2753 +/- ## ======================================= Coverage 99.42% 99.42% ======================================= Files 13 13 Lines 2605 2605 ======================================= Hits 2590 2590 Misses 15 15 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `99.42% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [taxcalc/\_\_init\_\_.py](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753?src=pr&el=tree&filepath=taxcalc%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-dGF4Y2FsYy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [taxcalc/calculator.py](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753?src=pr&el=tree&filepath=taxcalc%2Fcalculator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-dGF4Y2FsYy9jYWxjdWxhdG9yLnB5) | `100.00% <ø> (ø)` | | | [taxcalc/parameters.py](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2753?src=pr&el=tree&filepath=taxcalc%2Fparameters.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-dGF4Y2FsYy9wYXJhbWV0ZXJzLnB5) | `100.00% <ø> (ø)` | |
bodiyang commented 2 months ago

@jdebacker have update the documentation. current testing failure is from the codecov ~ probably we can have a rerun of the tests