search

PSLmodels / taxdata

The TaxData project prepares microdata for use with the Tax-Calculator microsimulation project.
http://pslmodels.github.io/taxdata/
Other
21 stars 30 forks source link

Move impute_pencon targets to csv #435

Closed andersonfrailey closed 1 year ago

andersonfrailey commented 1 year ago

This PR moves the targets used in impute_pencon.py from a string in the python file to separate CSV files. The argument for doing this is that these targets are specific to the 2011, so when we update TaxData to be compatible with more recent versions of the PUF we'll need to use different targets. This PR will allow us to add new targets, while keeping the old ones for backwards compatibility.

I compared the resulting PUF to the PUF created from the master branch and while the column order is difference (see issue #433), the values in the PUF are the same.

andersonfrailey commented 1 year ago

If there are no objections, I will merge this at the end of the day

jdebacker commented 1 year ago

LGTM @andersonfrailey!