Closed schulz0r closed 3 years ago
Hello Phillip
I liked your idea of creating a PSOPT namespace. I have added pi to the namespace as well. The namespace needs to be included by the user if the double constants inf and pi are to be used just like that. Otherwise, the user will need to employ PSOPT::inf and PSOPT::pi. I have also defined the value of inf using the std:numeric_limit
Hello, As the title says, psopt.h defines a variable which is a class in the geometry library CGAL. That's why programs which make use of both dependencies cannot compile. I suggest that you use
std::numeric_limits<T>::infinity
from the headerlimits
so that you don't need to define your own infinity. Edit: Since there are no tests, I cannot simply commit the proposed solution. After all, I am changing a variable. I still need to fix this issue as soon as possible, so I will go the safe route and putinf
into anamespace
and fix all compile errors. I guess this won't break anything.Best regards
Philipp