search

PSPDFKit-labs / bypass

Bypass provides a quick way to create a custom plug that can be put in place instead of an actual HTTP server to return prebaked responses to client requests.
https://hex.pm/packages/bypass
MIT License
964 stars 111 forks source link

Switch from :simple_one_for_one to DynamicSupervisor #87

Closed anthonator closed 4 years ago

anthonator commented 4 years ago

Closes #86

anthonator commented 4 years ago

Anything I can do to help push this along?

anthonator commented 4 years ago

@MSch anything I can do to help get this merged?

mhsdef commented 4 years ago

@MSch's last commit 2018... 🤔

I really want to use Bypass but this warning is quite the nuisance.

ream88 commented 4 years ago

Hey Mario here, this will be merged soon: https://github.com/PSPDFKit-labs/bypass/issues/88 😊

TheFirstAvenger commented 4 years ago

@ream88 Can we have a 1.0.1 pushed to hex with this change?

ream88 commented 4 years ago

As this just generates an ugly deprecation message, but merging it would break compatibility with Elixir < 1.6, I say wait for 2.0.

/cc @MSch Wait is your opinion?

TheFirstAvenger commented 4 years ago

What is the current eta on 2.0?

thiamsantos commented 4 years ago

@ream88 Those changes will come with version 2.0? I would like to get rid of the compile warnings.