PSU-CSAR / bagis-pro

BAGIS for ArcGIS Pro
4 stars 1 forks source link

ArcGIS Pro 3 is now available #36

Open lbross opened 2 years ago

lbross commented 2 years ago

This is a major release and it seems that our add-in will not be forwards compatible. It will need to be recompiled. There are also major changes on the Python side which impact that awdb script. There is not a compelling reason to update immediately but we should get this on the roadmap.

http://geospatialtraining.com/whats-new-in-arcgis-pro-3/

lbross commented 2 years ago

The current 2.8.2 add-in does not run on ArcGIS Pro 3. PSU has decided to deploy ArcGIS Pro 3 in our labs. Set up an ArcGIS Pro 3 development environment on CS1 to vet our BAGIS-PRO add-in and the Python scripts that load the awdb layers.

lbross commented 1 year ago

I just published an addIn for v3.0.x to the basins server! It is in a folder called /BAGIS/BAGIS_addins/BAGIS PRO/v3.0.1. Please test it at your leisure.

lbross commented 1 year ago

I tested running the awdb-retrieve scripts from CS1 which is running ArcGIS Pro 3. The scripts ran without issue. I feel confident upgrading basins to ArcGIS Pro 3 when we are ready to make the switch.

lbross commented 1 year ago

In the addIn I just posted, we now query the registry for the Chrome path, in case it is installed in a non-standard location. If it's not found, an error is printed to the log. I plan to upgrade basins to ArcGIS Pro 3 next week. This will be used when running the awdb scripts and posting to AGOL.

jdduh commented 1 year ago

The addin works fine on ArcPro 3.1.1. I notice a few issues.

  1. The font size on the summary page seems to be larger on this version. The two circled lines are single lines in ArcPro 2.X version. Also the end of the site location analysis almost overlaps with the credit paragraph. The same issue for the data sources and site table pages.

image

  1. The last line of the description on the critical precipitation zone table is missing. Here is a screenshot from 2.x. image

And from 3.X

image
  1. The Jan 1 SNODAS Mean SWE is missing from the map. image

    I verified that the raster is in the analysis.gdb

    image

That's all. I have put a copy of the AOI on the ftp server. The file name is lake_mary_reservoirinflow(2)_09202010.zip

lbross commented 1 year ago

Thanks for taking a look at this. There is a new add-in on basins for you to try at /BAGIS/BAGIS_addins/BAGIS PRO/v3.0.1. I noticed a patch for Pro so CS1 is now running v3.1.1. This is the version that created the report I posted.

  1. This is a function of swapping out Chrome for the html-to-pdf library that we can no longer use with v3.x. I specified a font size of 14px for the summary, data sources, and site tables. I also forced the elevation column to be narrower on the site tables. If it still seems too big, we can try 12px on selected pages or all of them.
  2. I wasn't able to recreate the error with the critical precipitation zones chart. I added a line to the AOI log that should look something like this: Print area: $A$1:$P$23. If you continue to have this issue, we can interactively load the Excel charts and see if this print area is correct.
  3. This is the issue I told you about on Thursday that I spent a multiple days on last week. CS1 generated this page correctly. I am out of ideas to try next. This is the call to each mapFrame that doesn't seem to work consistently:

    Map m = mapFrame.Map;
    //Get the specific layer you want from the map and its extent
    FeatureLayer lyr = m.FindLayers("Basin Boundary").First() as FeatureLayer;
    mapFrame.SetCamera(lyr);

The next step should probably be to open a case with ESRI, as it seems this is a problem somewhere with marshalling the SetCamera function, but it's tough to come up with a use case for them to recreate. It's in the middle of a complex algorithm.

I placed my report for 09400910_AZ_USGS in the same folder as the new 3.x addIn. You will (hopefully) see that items 2 and 3 aren't manifested in this report.

jdduh commented 1 year ago

I have created a separate folder (BAGIS PRO 3.X) to hold the addins for ArcGIS Pro 3.X and put a copy of the latest 2.X addin (dated 3/13/2023) in the BAGIS PRO 2.X folder. I will report back if I am able to get around the mapFrame issue.