search

PSU-CSAR / snodas-ui

SNODAS Tools UI
0 stars 1 forks source link

fixes for compatibility with new API #6

Closed jkeifer closed 2 months ago

jkeifer commented 2 months ago

I made some changes to the API response for the get pourpoints endpoint (removed pourpoint_id as it duplicates the feature ids, and rename awdb_id to station_triplet), which ended up breaking things in the UI. This PR fixes the issues.

Also included is a change to ensure that stats cannot be requested for a non-polygon pourpoint, as doing so will always return an empty CSV file (validation for such a case is not part of the legacy API endpoints).

The corresponding changes to the API are part of this PR: https://github.com/PSU-CSAR/django-snodas/pull/7. It has not been reviewed/merged yet, but that branch (and this branch) is currently deployed.

jkeifer commented 2 months ago

Yep, this branch is what is currently running on basins. Thanks for the review!

jdduh commented 2 months ago

Thanks for the deployment on basins. The issue has been resolved and the interface is working as expected.