PSU-CSAR / vb-bagis-p

VB .NET source code for ArcMap BAGIS Parameters add-in
1 stars 1 forks source link

Subaoi tool - error #54

Open jdduh opened 2 years ago

jdduh commented 2 years ago

Got this error message when "Creating SubAOI ID Layer Using Selected SubAOI(s)." I tried the tool on both ArcMap 10.8.1 and 10.5.2. and got the same error message. The tool left several temp rasters in subaoi.gdb. If you delete the subaoi.gdb, then the tool seems to work until the next time it sees the subaoi.gdb in the AOI folder.

image

lbross commented 2 years ago

I've been looking back at old emails for when we originally created this tool. It looks like we had some trouble with the combine tool back when it was created, so this is not surprising. I am remembering/validating how this tool was originally designed to work before making changes. It will probably take some time. Let me know if something else is a higher priority.

jdduh commented 2 years ago

The BAGIS/PRMS5 interfacing tasks are not urgent. We have a workaround for this bug (by deleting the subaoi.gdb folder). Let's come back to this bug when we have finished the Basin Analysis Report batch tool.

lbross commented 2 years ago

Can you successfully append the sub aoi id to the parameters file using the Profile Builder? I keep getting an error with the zonal statistics as table tool. It's hard to pinpoint, but I think it may be a problem in a previous step that uses the old IMapAlgebraOp from the spatial analyst ArcObjects api. These "Op" functions seem to be less and less stable with every new version of ArcMap. I should probably try changing it to the geoprocessor if you also have trouble.

Update: Interestingly the tool that creates the sub aoi id layer and the tool that appends the sub aoi id to the parameters file BOTH use the function with the old IMapAlgebraOp step. I should probably switch this to the GP and see if it fixes both ...

lbross commented 2 years ago

This is fixed. I think the main issue was using a vector for the snap raster. Not sure why I did this originally or why earlier versions of ArcMap tolerated it, but ... I also switched the iMapAlgebra calls over to the geoprocessor as long as I was in there. I can do a new build whenever you need one, but may want to wait for the other subaoi enhancements? This problem prevented me from creating a subaoi layer and from exporting the parameters with the subaoi id.