search

PSU-CSAR / vb-bagis

Source code for BAGIS V3 ESRI Add-In
0 stars 1 forks source link

Auto pseudo site tool - "Location" constraint using raster data #41

Closed jdduh closed 7 years ago

jdduh commented 7 years ago

Adding a new "Location" constraint that allows users to select a discrete raster layer and specify a list of cell values for limiting the auto site search. The GUI should be similar to BAGIS-H's parent HRU layer function. It would also be desirable to list all the attribute fields, instead of just the cell value, on the value list to make the selection of value(s) easier. See #42 for raster layer list spec.

image

lbross commented 7 years ago

Should the values specified be included or excluded in the search?

jdduh commented 7 years ago

The selected values should be included (i.e., exclude not selected values) in the search. Change the label caption to "Limit the search on selected zones." If no value is selected, then prompt a warning message and uncheck the Location checkbox.

lbross commented 7 years ago

Looking at the sample GUI on p. 6 of site scenario prototype. Do we need to have the checkbox on the far left-hand side? It would look cleaner without. If the layer is in the grid, it would be used. Also, I am going to experiment with putting the pick lists inside the grid and see if that works.

jdduh commented 7 years ago

Deletion is performed on one entry at a time. There is no need to have the checkbox.

jdduh commented 7 years ago

The GUI design is spot-on and the tool seems to work correctly. Here are some minor issues.

  1. Partially obscured GUI. image

  2. Activation of the delete and edit buttons. Users must click on the first (heading) column to activate the delete and edit button. Is there a way to activate the button when any cell in the list is clicked? See the two activation condition images below.

    • Heading column (i.e., whole row) is selected image

  1. Add the following text to the Frame caption "Location - limit search in the intersection of the conditions specified below." Similar text also needs to be added to the Proximity constraint. image

  2. Add the following text to the tool description: ". The overlay of multiple constraints is based on AND (i.e., intersect) operation." image

jdduh commented 7 years ago

A potential issue (or is it just me?) - the "Done" button captions should be renamed to something else, like "Close" or "Exit." Every time when I was done setting up the constraints, I naturally clicked on "Done," which cancels my last setup.

image

lbross commented 7 years ago

I can rename the button to "Close". In addition, I could close the selection window when the 'Save' button is pressed. The user would have to open the form again to add another constraint but my guess is they will most often use one layer at a time. Thoughts?

jdduh commented 7 years ago

Please close the selection window after the 'Save' button is pressed. Rename 'Done' to 'Cancel.'

lbross commented 7 years ago

I have updated the functionality as requested. I think this makes the form more usable. This will be in the next release of BAGIS V3.

jdduh commented 7 years ago

Unable to open the Site Scenario tool. The menu item remains disabled no matter what.

image

lbross commented 7 years ago

I have not encountered this issue. My usual workflow is to set the current AOI using the AOI Info tool. If the maps tool has been run then the Site Scenarios tool should be enabled. BAGIS checks for the presence of the analysis.gdb\elevzone layer before enabling the Site Scenarios button as this is the base layer for all of the site scenario maps. Next troubleshooting steps would be:

  1. Check for the presence of the elevzone layer in the AOI. If this layer isn't being created, we may have a bug there.
  2. Let me know if you are following a different path to enable the Site Scenarios tool
  3. If neither of the above works, can you upload the AOI so I can try to replicate? You didn't say if this is with one or many AOI's. If many, we may have an ArcGIS version issue :-(
jdduh commented 7 years ago

This problem went away... I'm not sure what was causing it. I did notice that after updating a new add-in, the add-in usually won't behave 100% correctly the first time ArcMap was restarted. Users needed to restart ArcMap again to clean up some of the leftover information.

lbross commented 7 years ago

The process that has worked for me in the past is:

  1. Use the ArcMap add-in manager to delete the old add-in
  2. Restart ArcMap
  3. Install the new add-in

But maybe we need to add a step 4 to restart again? Glad the problem went away.