PSU-CSAR / vb-bagis

Source code for BAGIS V3 ESRI Add-In
0 stars 1 forks source link

ArcGIS 10.5 compatible issues #60

Closed jdduh closed 5 years ago

jdduh commented 6 years ago

Please RDP to GGR-CH-424H-G0 to test BAGIS and ArcGIS 10.5 (and later) compatibility. There is an issue with RDP setup on the machine. I will update this document when the issue is resolved.

lbross commented 6 years ago

So I shouldn't try to RDP until I hear back from you that the issue is fixed? Can you install VS Express 2010 here as well so that I can debug and compile? Also ArcObjects SDK? If I can't debug, the best I can do is MessageBox errors and I probably won't be able to fix anything unless I can compile against the new version.

lbross commented 6 years ago

Actually according to ESRI's website, we will need either Microsoft Visual Studio 2013 VB .NET or Microsoft Visual Studio 2015 VB .NET Community edition to install the SDK and compile the add-in for 10.5.

jdduh commented 6 years ago

The RDP issue has been resolved. You should be able to connect to the computer with your ODIN account. I have also installed MS VS 2015 VB .NET Community edition and ArcGIS 10.5.1 SDK on the computer.

jdduh commented 6 years ago

After selecting a pourpoint and proceeding to clipping AOI layers, this error occurred. This error is specific to ArcGIS 10.5 (or later versions).

image

lbross commented 6 years ago

I'm having trouble connecting to this computer. I have VPN'd into PSU. I am using GGR-CH-424H-G0 for the computer name and PSU\lbross for the user name. Do you have any suggestions for me to try? Do I need to fully qualify the computer name? I have tried both geog.pdx.edu and psu.ds.pdx.edu.

jdduh commented 6 years ago

I just tested the connection and it worked. The computer name is ggr-ch-424H-G0.psu.ds.pdx.edu. You should log on with PSU\lbross.

Jiunn-Der (Geoffrey) Duh

Geography, Portland State University

Cramer Hall 424, 1721 SW Broadway

Portland, OR 97201, USA

tel: +1-503-725-3159 fax: +1-503-725-3166

web.pdx.edu/~jduh

On Mon, Jun 18, 2018 at 10:47 AM, Lesley notifications@github.com wrote:

I'm having trouble connecting to this computer. I have VPN'd into PSU. I am using GGR-CH-424H-G0 for the computer name and PSU\lbross for the user name. Do you have any suggestions for me to try? Do I need to fully qualify the computer name? I have tried both geog.pdx.edu and psu.ds.pdx.edu.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PSU-CSAR/vb-bagis/issues/60#issuecomment-398138536, or mute the thread https://github.com/notifications/unsubscribe-auth/AK-jtOT8BTtjPEAF3L5e9papKEB85MlLks5t9-epgaJpZM4UNPmY .

lbross commented 6 years ago

I was able to connect with the computer and run Visual Studio

lbross commented 6 years ago

Unfortunately we need to load 2 more pieces of software to this computer for the development environment: Git For Windows 2.0 and TortoiseGit. I tried to install TortoiseGit this morning and it requires admin privileges. I downloaded both software installers to the Downloads folder on the lab computer. There are some configuration suggestions on this page for the Git For Windows install. If it's possible to give me admin privileges, I could do the installations myself.

My plan is to create a separate branch for 10.5 so we can merge changes down from the master branch and maintain it separately for a while as needed. I hope this is all we have to install but it's been a while since I installed TortoiseGit.

One of the first things I will look at once I get it working is issue #62. I have a feeling this is a version incompatibility issue and migrating to 10.5 may provide some insight.

lbross commented 6 years ago

Made some progress on this. Needed to remove and re-add references to GISClient and Server. Got strange errors related to IGPProcess that I couldn't resolve or find information about. Switched to .NET Framework 4.5 and these went away. There were a couple of obsolete syntax lines that needed to be fixed. Now I am stuck with this error: The "ValidateAddInXMLTask" task failed unexpectedly. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.Shell.12.0, Version=12.0.0.0

Per ESRI support we need to install an additional component for Visual Studio 2015. I do not have installation privileges. https://support.esri.com/en/technical-article/000012659

jdduh commented 6 years ago

Both Github for Windows and TortoiseGit were installed. Please give them a try.

jdduh commented 6 years ago

Visual Studio 2013 Shell was also installed.

lbross commented 6 years ago

Making good progress. Got add-in to compile and debugger to run. Here are some changes I needed to make:

  1. Remove and re-add ESRI.ArcGIS.ADF.Connection.Local library. This was confusing because the library didn't show up on the list to add. I needed to browse to it. But once I found it, I could add it.
  2. Change these 2 tags in the Config.esriaddinx file: <Target name="Desktop" version="10.5" /> <AddIn language="CLR" library="BAGIS.dll" namespace="BAGIS">

Getting the debugger to work:

  1. Create test ArcMap project in 10.5 to generate *.vbproj.user file. Rename and copy into BAGIS project
  2. Set ArcMap as 'Start External Program' in debug section of project properties
lbross commented 6 years ago

Apparently the pHydrologyOp.SnapPourPoint() method has changed between 10.2.2. The pourpoint is now indicated with a value of '1' instead of '0'. This means that the 10.5 code will need to remain a separate branch from 10.2.2. I will do a search to see if we use SnapPourPoint() elsewhere in BAGIS

Note that the IGxDialog also seems to take a much longer time to load than in previous versions. Actually most interactions with ArcCatalog are slower.

lbross commented 6 years ago

Need to set 'Copy Local' settings for ESRI libraries to false to make add-in package smaller. Visual Studio appears to randomly change this setting when importing the older project.

lbross commented 5 years ago

We have deployed an add-in for AGS 10.5. Code for the add-in will be maintained on GitHub branch ags_10.5. My methodology is to fix any bugs in the master branch (10.2.2) and to merge these fixes into the ags_10.5 branch so the branches stay as close as possible prior to 10.5's promotion to the supported version.