Open skleinfeldt opened 3 years ago
The byline and "Read more..." link should be removed from the stock Plone Summary View.
Implemented, in master. Summary view currently in use here: https://beta.equity.psu.edu/web/offices
The Folder Summary view looks good although we would like to not display the lead image if it is set and discuss adding a new story for a custom folder summary view that includes displaying images.
@paulrentschler There's a control panel setting for that (a few of them actually):
https://beta.equity.psu.edu/web/@@site-controlpanel#form-widgets-no_thumbs_portlet
@alecpm that's a cool control panel that definitely did not have all those cool options in Plone 4. Unfortunately, I selected the "No thumbs in summary views" option and when loading the Offices page got a traceback:
Traceback (innermost last):
Module ZPublisher.WSGIPublisher, line 162, in transaction_pubevents
Module ZPublisher.WSGIPublisher, line 371, in publish_module
Module ZPublisher.WSGIPublisher, line 266, in publish
Module ZPublisher.mapply, line 85, in mapply
Module ZPublisher.WSGIPublisher, line 63, in call_object
Module zope.browserpage.simpleviewclass, line 41, in __call__
Module Products.Five.browser.pagetemplatefile, line 126, in __call__
Module Products.Five.browser.pagetemplatefile, line 58, in __call__
Module zope.pagetemplate.pagetemplate, line 133, in pt_render
Module Products.PageTemplates.engine, line 378, in __call__
Module z3c.pt.pagetemplate, line 176, in render
Module chameleon.zpt.template, line 302, in render
Module chameleon.template, line 214, in render
Module chameleon.utils, line 53, in raise_with_traceback
Module chameleon.template, line 192, in render
Module 21c4cf128bad7545198495d7cb899d31, line 650, in render
Module 2d1571356263e8cd1c946fe23f300f29, line 860, in render_master
Module 2d1571356263e8cd1c946fe23f300f29, line 1489, in render_content
Module 21c4cf128bad7545198495d7cb899d31, line 635, in __fill_content_core
Module 21c4cf128bad7545198495d7cb899d31, line 387, in render_content_core
Module 720ac2df5e24b26392deaed5ddf34996, line 122, in render_content_core
Module 720ac2df5e24b26392deaed5ddf34996, line 505, in render_listing
Module 21c4cf128bad7545198495d7cb899d31, line 360, in __fill_entries
Module 720ac2df5e24b26392deaed5ddf34996, line 952, in render_entries
Module 21c4cf128bad7545198495d7cb899d31, line 196, in __fill_entry
Module zope.tales.pythonexpr, line 73, in __call__
- __traceback_info__: (item_url + '/@@images/image/' + thumb_scale_summary)
Module <string>, line 1, in <module>
TypeError: can only concatenate str (not "NoneType") to str
Apparently, this is a very old issue:
https://github.com/plone/plone.app.contenttypes/issues/486
I'll make a quick PR and we'll see what happens.
Since @witekdev made a custom version of this view I was able to fix the bug in your custom version of the template. It should be resolved once you run buildout (and maybe restart). I still plan to make a PR, but there's no need to wait for it in this case.
This looks good now, thx.
As a user I can see the contents of a folder displayed in "Summary View" using title and text styles consistent with the rest of the site.
This story is about styling the existing Plone Summary View. If it is decided that all content on the site will have lead images, and the lead images should be shown in a custom summary view, then another story should be added.