Open skleinfeldt opened 3 years ago
Since this requires plone.app.imagecropping, this work should probably be based on the story/5-addons
branch which includes/installs the add-on. It should be possible to set registry settings in the profile to configure auto-cropping, croppable scales, and use the typeinfo profile step to add the croppable behavior to types that have images/leadimages.
Image crops attached:
@alecpm would you be able to have a look as to why my registry settings for cropping_for
and constrain_cropping
are not taking? Maybe its something thats obvious to you? Commit here: https://github.com/PSUEducationalEquity/plonetheme.eeq/commit/a698c0fa311661debb171c06629fcf8b575a8f28
Thanks!
Also looks like auto-cropping is not implemented at the moment? https://github.com/collective/plone.app.imagecropping/blob/master/src/plone/app/imagecropping/browser/settings.py#L47
@alecpm likewise Image cropping behavior is set for Document and Collection. I'm not sure for which other standard types it needs to be set for? If any?
Auto-cropping is enabled automatically when scales are constrained, IIRC so it's not yet settable.
The crop behavior should be enabled for all types that have lead images.
Per standup meeting today, "updated" image cropping is as follows:
Hero Image = 1900 x 275 pixels @72 pixels resolution Office Tile = 396 x 32 pixels @72 pixels resolution (Narrow strips on main landing page for each office.) Content Tile = 335 x 200 pixels @72 pixels resolution (News images and features.)
@MBrahosky Looks like Office tile is a new crop and there's no longer a square crop that you're concerned with.
@alecpm Actually, let's keep the square image crop as well. Paul believes this had another purpose.
@MBrahosky OK, I've updated the crops in the package profile and on the site. @paulrentschler If you could run an update on the site I think we can see the crops and the working implementation of #28 as well.
As a content editor I can create crops of images appropriate to the site design for all images and lead images on the site. Available crops will be:
Note that if other crop sizes are required in the future, PSU staff will be able to add them.
plone.imagecropping
behavior for content types that are used in tiles and portlets (e.g. collection portlets and content summary tiles).