Add header navigation to the theme

PSUEducationalEquity / plonetheme.eeq

Plone Diazo theme for Penn State Educational Equity website

0 stars 0 forks source link

Add header navigation to the theme #37

Closed silviot closed 3 years ago

silviot commented 3 years ago

See #7

There are a couple of issues with bootstrap javascript and CSS:

the links in the top nav are underlined when hovered (we should make sure bootstrap css are loaded last to fix this)
the button to show/collapse navigation on mobile is broken (I suspect the inclusion of jquery and bootstrap javascripts needs to be looked into)

alecpm commented 3 years ago

I think adding the bootstrap.js to match the CSS that we're loading will help. Plone also loads bootstrap with the patterns, but I believe it does so piecewise via requireJS, so we may be able to just load the file. A newer jQuery might be a good idea (from a security perspective especially, but that requires a custom mockup build, which I'm reluctant to get into. I think the best way to manage the ordering of bootstrap load is by compiling it into the main css, but I can explore that later.