search

PSUmodeling / Cycles

Cycles agroecosystem model
https://psumodeling.github.io/Cycles/
Other
11 stars 0 forks source link

NMineralConcentration #11

Closed gcamargo1 closed 9 years ago

gcamargo1 commented 9 years ago

Armen/Yuning,

The statement: NMineralConcentration = Soil->NO3[i] / soilMass;

shouldn't be: NMineralConcentration = Soil->NMineral / soilMass;

in line 294 of SoilCarbon.c?

shiyuning commented 9 years ago

Armen: I think Gustavo is right. And it was wrong in the original Cycles. What is the effect? Not much. Luckily enough, there is no N balance problem. Fixing this will change the C:N ratio of the destiny pool, making it lower, and demanding a little more N for immobilization.

Charlie: That sounds right. In real soils, NH4+ is usually low relative to NO3-, though it depends on time of year, so hopefully the change will have only minor effects as Armen suggests.