Closed rongcuid closed 1 year ago
As a note, since I am using Box<dyn Writer>
, I cannot actually call .finish()
. In my opinion, this should really be called on drop()
.
edit:
zstd
provides a type called AutoFinishEncoder
. Maybe you can add something like this?
Thanks for the suggestion, I added auto_finish
for FrameEncoder
on the main branch. Can you test if that works for you?
I think it works.
Okay cool, I'll try to make a release next week
I'd just like to check on the status, thanks
I'm preparing a release. I did a lot of changes before auto_finish
and want to make sure everything works properly (fuzzing, benchmarks etc.).
Released with 0.11
When I use
FrameEncoder
, the last part of the file is not actually written properly:Using
lz4cat
on resulting file givesError 68: unfinished stream
.I need this boxing because I am generalizing multiple output backends with
Box<dyn Write>
. I am not sure if this is causing the issue here, butflate2
with its gzip decoder closes files properly.