Closed TianyiShi2001 closed 2 years ago
Looks good except minor comment regarding naming.
I think it would be good to keep the API, to avoid break if it is not necessary, but the docs should be updated to use the traits as the preferred way.
Any reason this isn't merged? I'm considering using this library for a project, and it seems like work is done.
Sorry completely forgot about that, I will look at it tomorrow
Looks good, thank you!
@magnus-ISU @TianyiShi2001 released with 2.1.0 https://crates.io/crates/wana_kana
This PR addresses issue #7 . Three traits are being implemented, which allows ergonomic conversion between kana and romaji; checking whether a
&str
is Japanese; and checking whether achar
is Japanese, using default options (although additional methods with a_with_opt
suffix can be added to these traits, which can fully replace the current API). Should we deprecate the old functions and fully migrate to the new API in the next major version, or should both sets of API be kept?Examples: