[joss-review] Feedback on paper

PSims / BayesEoR

Code to estimate the power spectrum of redshifted 21-cm emission from interferometric observations, within a Bayesian forward modelling framework.

https://bayeseor.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

[joss-review] Feedback on paper #25

Closed zonca closed 2 months ago

zonca commented 2 months ago

Statement of need

[x] Please explain where the 21-cm emission comes from
[x] Gyr is too technical for the statement of need

Summary

Just a bit more details on the process

[x] it would be useful to specify what parameters of an instrument you can characterize
[x] also specify what is the format of the input data, are those timelines of some sort?
[x] do you generally run this full-sky or works in patches?
[x] do you use any other inputs besides instrument parameters and instrument data?

Figure 1

Explain terminology

[x] phi
[x] k
[x] $\Delta K$

zonca commented 2 months ago

also "Do the authors describe how this software compares to other commonly-used packages?", aren't there other codes doing something similar?

jburba commented 2 months ago

Hi @zonca , I think I've addressed your suggestions. Please give the most recent version of the paper a read and let me know what you think. I've also updated the documentation to include some more information about the inputs and more detail on running the analysis.

zonca commented 2 months ago

text is good, can you explain the terminology in the figure? best would be to add a caption.

jburba commented 2 months ago

The figure caption only seems to appear in the pdf, not the markdown file. I'm not sure why that is.