PTB-M4D / PyDynamic

Python library for the analysis of dynamic measurements
https://ptb-m4d.github.io/PyDynamic/
GNU Lesser General Public License v3.0
25 stars 13 forks source link

Feature: GUM_iDFT support for odd output signals, as well as over- and undersampling #311

Closed mgrub closed 1 year ago

mgrub commented 1 year ago

This PR provides a solution for #310 and with that enables DFT-identity of odd signals. Moreover, GUM_iDFT now fully supports the numpy.fft.irfft(..., n=...) argument, which means, a signal can be up- or downsampled (aka Fourier interpolation) and the formerly raised "ValueError If Nx is not smaller than dimension of UF - 2" is obsolete.

An appropriate test is provided, which tests multiple length-combinations.

TODO:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 82.14% and project coverage change: +0.09 :tada:

Comparison is base (ab2174d) 77.25% compared to head (b27418b) 77.34%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## ========================================== + Coverage 77.25% 77.34% +0.09% ========================================== Files 29 29 Lines 2242 2269 +27 Branches 366 370 +4 ========================================== + Hits 1732 1755 +23 - Misses 382 386 +4 Partials 128 128 ``` | [Impacted Files](https://codecov.io/gh/PTB-M4D/PyDynamic/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D) | Coverage Δ | | |---|---|---| | [src/PyDynamic/misc/tools.py](https://codecov.io/gh/PTB-M4D/PyDynamic/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D#diff-c3JjL1B5RHluYW1pYy9taXNjL3Rvb2xzLnB5) | `62.02% <69.23%> (+0.54%)` | :arrow_up: | | [src/PyDynamic/uncertainty/propagate\_DFT.py](https://codecov.io/gh/PTB-M4D/PyDynamic/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D#diff-c3JjL1B5RHluYW1pYy91bmNlcnRhaW50eS9wcm9wYWdhdGVfREZULnB5) | `67.29% <93.33%> (+1.72%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/PTB-M4D/PyDynamic/pull/311/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.