search

PTB-M4D / PyDynamic

Python library for the analysis of dynamic measurements
https://ptb-m4d.github.io/PyDynamic/
GNU Lesser General Public License v3.0
25 stars 13 forks source link

Fix covariance of `GUM_iDFT` output #315

Closed mgrub closed 1 year ago

mgrub commented 1 year ago

This PR addresses issue #314 by fixing the expression given in eq. 22 of the corresponding paper . The main fix is given by commit 682cd4b0 .

Moreover, the DFT-IDFT-identity check is extend to cover the case of a full covariance matrix. Two Monte-Carlo tests are introduced to validate the GUM_DFT and GUM_iDFT results, but are marked with pytest.mark.skip for now.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% :warning:

Comparison is base (e785e07) 77.39% compared to head (d32d7f1) 77.36%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #315 +/- ## ========================================== - Coverage 77.39% 77.36% -0.03% ========================================== Files 29 29 Lines 2278 2280 +2 Branches 372 372 ========================================== + Hits 1763 1764 +1 - Misses 390 391 +1 Partials 125 125 ``` | [Files Changed](https://app.codecov.io/gh/PTB-M4D/PyDynamic/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D) | Coverage Δ | | |---|---|---| | [src/PyDynamic/uncertainty/propagate\_DFT.py](https://app.codecov.io/gh/PTB-M4D/PyDynamic/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D#diff-c3JjL1B5RHluYW1pYy91bmNlcnRhaW50eS9wcm9wYWdhdGVfREZULnB5) | `67.47% <100.00%> (+0.17%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/PTB-M4D/PyDynamic/pull/315/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PTB-M4D)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BjoernLudwigPTB commented 1 year ago

Looks, as if for 20.000 runs Python 3.7 needs more time. Could you please adjust the deadline?

Should be fixed in d32d7f1.