Closed mgrub closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.53%. Comparing base (
b9debd7
) to head (05bc0d5
). Report is 2 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR defines a variable "
custom_atol=100*machine_epsilon
" in theconftest.py
and uses it in all assert_allclose statements, that did not already declare a (larger) absolute tolerance previously.Motivation:
numpy.testing.assert_allclose
uses default values ofrtol=1e-7
andatol=0
. This is sometimes difficult to achieve if mathematically equivalent but numerically different routines are compared, especially for array entries close to zero. The proposed absolute tolerance should provide a good compromise between achievable numerical accuracy and detecting true deviation of arrays in tests.