Sequence instead of tuple or list for input typehints

PTB-MR / mrpro

MR image reconstruction and processing.

https://ptb-mr.github.io/mrpro/

Apache License 2.0

17 stars 2 forks source link

Sequence instead of tuple or list for input typehints #198

Closed fzimmermann89 closed 7 months ago

fzimmermann89 commented 8 months ago

We should maybe use collections.abc.Sequence[type] for hinting input types instead oflist[type]or tuple[type,...](i.e. tuples of arbitrary length). This allows both, tuples and lists as inputs.

Quick search reveals the following functions we might need to

[ ] FastFourierOp
[ ] ZeroPadOp
[ ] zero_pad_or_crop
[ ] smap
[ ] KHeader.from_ismrmrd conversion functions
[ ] EllipsePhantom

fzimmermann89 commented 8 months ago

I think I got all in the ruff PR..