PTB-MR / mrpro

MR image reconstruction and processing.
https://ptb-mr.github.io/mrpro/
Apache License 2.0
13 stars 3 forks source link

Fix warning in pickle test #372

Closed ckolbPTB closed 2 months ago

ckolbPTB commented 2 months ago

Due to a bug in pytorch there is a FutureWarning when calling pickle of a tensor: https://github.com/pytorch/pytorch/issues/130658

This will be solved with pytorch 2.4.1. I added an issue to remove @pytest.mark.filterwarnings('ignore::FutureWarning') again when we require at least 2.4.1.

Fixes one error reported in #371

github-actions[bot] commented 2 months ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms/csm
   iterative_walsh.py15193%52
src/mrpro/algorithms/dcf
   dcf_voronoi.py53492%29, 62–63, 90
src/mrpro/algorithms/optimizers
   adam.py17194%78
src/mrpro/algorithms/reconstruction
   DirectReconstruction.py613641%66–71, 88–96, 108–110, 126–133, 147–158
   Reconstruction.py8188%34
src/mrpro/data
   AcqInfo.py123298%176, 214
   CsmData.py21386%28, 72–74
   DcfData.py37295%31, 79
   IData.py61395%138, 144, 148
   IHeader.py65297%90, 117
   KHeader.py1611293%37, 139–143, 178, 228, 239, 246–247, 250, 257
   KNoise.py24962%53–66
   MoveDataMixin.py1261489%28, 122, 138, 152–154, 215, 278, 292, 371, 391–392, 409–410
   QData.py32197%56
   SpatialDimension.py44198%78
   TrajectoryDescription.py14193%37
   acq_filters.py10190%61
src/mrpro/data/_kdata
   KData.py97991%121–122, 131, 139, 193–194, 229, 234–235
   KDataRemoveOsMixin.py29293%55, 57
   KDataSelectMixin.py20290%60, 76
   KDataSplitMixin.py48394%63, 93, 102
src/mrpro/data/traj_calculators
   KTrajectoryCalculator.py25292%37, 59
   KTrajectoryIsmrmrd.py13285%55, 64
   KTrajectoryPulseq.py29197%68
src/mrpro/operators
   CartesianSamplingOp.py50982%63–64, 69–70, 75–76, 102, 105, 128
   ConstraintsOp.py60297%60, 62
   EndomorphOperator.py51296%223, 227
   FiniteDifferenceOp.py27293%62, 127
   FourierOp.py77199%145
   GridSamplingOp.py122993%73–74, 83–84, 91–92, 95, 97, 99
   LinearOperator.py80495%46, 145, 265, 270
   Operator.py52198%35
   SliceProjectionOp.py166895%53, 60, 62, 68, 205, 226, 259, 299
   ZeroPadOp.py16194%44
src/mrpro/utils
   Rotation.py4532894%58–66, 106, 283, 369, 371, 398, 453, 458, 461, 476, 493, 498, 642, 647, 650, 666, 670, 745, 747, 755–756, 996, 1078
   filters.py61297%57, 62
   slice_profiles.py45687%32, 48, 125–128, 161
   sliding_window.py34197%46
   split_idx.py10280%57, 61
   zero_pad_or_crop.py31681%40, 44, 68, 71, 74, 77
TOTAL329619994% 

Tests Skipped Failures Errors Time
751 0 :zzz: 0 :x: 0 :fire: 1m 13s :stopwatch:
ckolbPTB commented 2 months ago

@schuenke I could not reproduce the errors in test_slice_projection_op_cube_rotation() and test_slice_projection_op_slice_batching() you reported in #371. Can you provide more info on when you encountered them?

schuenke commented 2 months ago

@schuenke I could not reproduce the errors in test_slice_projection_op_cube_rotation() and test_slice_projection_op_slice_batching() you reported in #371. Can you provide more info on when you encountered them?

I tried to reproduce the errors leading to our test failures and updated PyTorch in my local environment to 2.4.0. After this, I encountered the 3 errors listed in #371.

My environment: