PTB-MR / mrpro

MR image reconstruction and processing.
https://ptb-mr.github.io/mrpro/
Apache License 2.0
17 stars 2 forks source link

Public vs private attributes of instances #415

Open fzimmermann89 opened 1 month ago

fzimmermann89 commented 1 month ago

We should go through our code and check if all attributes that should not be changed on an initialized instance have a leading underscore in the name and consider adding a read-only property for them (if we think reading will useful)

This should mainly affect operators.

The rule is: leading underscore if forward (and adjoint) does not work as expected if you change the attribute. This might be because other variables depend on it.