search

PTB-MR / mrpro

MR image reconstruction and processing.
https://ptb-mr.github.io/mrpro/
Apache License 2.0
17 stars 2 forks source link

Binder build takes > 15min #457

Open fzimmermann89 opened 3 weeks ago

fzimmermann89 commented 3 weeks ago

It is a bit of a let down if you want to show one of the examples and it takes >15min until the binder is ready.

As a work around, we could specify the binder links with a tag. I.e. we have a 'release' tag that we move in our CD pipeline to the current commit. This way, the binder only has to be rebuild every release and not after every commit to main. As this will only happen every 2 weeks, we could even add final step to the CD pipeline that tries to open the binder and triggers and thus rebuild. Doing this on every commit to main feels wasteful to mybinder's resources, but every release feels reasonable to me.

Additionally, we could reevealute the use of our already build docker at mybinder.com, and how to also provide colab links as an option.

fzimmermann89 commented 3 weeks ago

@schuenke (wrote CD action) and @ckolbPTB (wrote the docker logic)

ckolbPTB commented 3 weeks ago

It would be great if somebody could check again how we could reuse our docker containers for binder. Maybe along these lines: https://github.com/jupyterhub/repo2docker-action?tab=readme-ov-file#mybinderorg

Adding colab links to the notebooks in our docu would also be nice.