search

PTDP / ptdp

Prison Telecom Data Project
2 stars 3 forks source link

Edited text to facilitate screenreader comprehension #16

Closed JoLynneMartinez closed 2 years ago

JoLynneMartinez commented 3 years ago

My NVDA screen reader read this page beautifully with just one exception. The text under "Our Goal" reads "We share the goals of #ConnectFamiliesNow, a collective ... ." The screen reader pronounces the organization name as "link number Connect Families now" or "visited link number Connect Families Now," which is confusing to the listener. I checked the Worth Rises and Connect Families now sites, and both refer to the organization in the test without the # sign except in the banner of the Connect Families Now site, which I suspect was done for visual/stylistic reasons alone. Therefore, I removed the # sign from the organization name in Masthead.tsx.

bytheway875 commented 3 years ago

JoLynne, can you make sure you’re making PRs against staging instead of master? I think we’re still doing all active work off of staging right now.

On Mon, May 24, 2021 at 4:49 PM Tod Robbins @.***> wrote:

@.**** approved this pull request.

👍🏻

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PTDP/ptdp/pull/16#pullrequestreview-667217393, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCJINOJMOUOI5LXD7NJTNDTPLCXFANCNFSM44IFDFCA .

JoLynneMartinez commented 3 years ago

I've only ever made PRs against the master. Please explain what you mean about making PRs against staging, and I will do so. Thanks, JoLynne

On Mon, May 24, 2021 at 4:52 PM Shannon Byrne @.***> wrote:

JoLynne, can you make sure you’re making PRs against staging instead of master? I think we’re still doing all active work off of staging right now.

On Mon, May 24, 2021 at 4:49 PM Tod Robbins @.***> wrote:

@.**** approved this pull request.

👍🏻

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PTDP/ptdp/pull/16#pullrequestreview-667217393, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABCJINOJMOUOI5LXD7NJTNDTPLCXFANCNFSM44IFDFCA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PTDP/ptdp/pull/16#issuecomment-847359659, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHCBW7M6ZUV7GUBORZ7AFTTPLDAXANCNFSM44IFDFCA .

bytheway875 commented 3 years ago

@JoLynneMartinez You can edit the "target" branch to be staging instead of master here on the PR page, or close this one to retarget against staging vs master. Locally, you can also check out into staging and pull the latest from staging in order to work off of staging and make sure you're working off of the latest in-progress work.