Fix naming of "handle_commit_maybe"

PTFS-Europe / koha-ill-bldss

1 stars 1 forks source link

Fix naming of "handle_commit_maybe" #15

Closed AndrewIsh closed 4 years ago

AndrewIsh commented 4 years ago

The naming of “handle_commit_maybe” is very misleading. As far as I can see from comments and old commits, it was intended to do more at some point but all it does, and has ever done, is redirect the user based on some conditions. A better name would be something simpler like “redirect_user”

AndrewIsh commented 4 years ago

This is actually a core issue, moved to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471