search

PTFS-Europe / rebus-list-2

rebus:list 2+ issue tracker repository
0 stars 0 forks source link

Rollover doesn't seem to be working #290

Open hloliver opened 7 years ago

hloliver commented 7 years ago

Hi

I've just been testing out the rollover feature but couldn't get it to work, I've tried it at unit and list level but nothing happens after clicking on the rollover icon. Short video below, if you hang on till the end you'll see the red error box which says 'no error details'!

http://www.screencast.com/t/axYcW8OwouH

can you take a look? thanks Helen

AndrewIsh commented 7 years ago

Hi Helen

Thanks for this. Can you confirm that you didn't have any success with this. I want to make sure before I try and do it myself!

Many thanks Andrew

hloliver commented 7 years ago

Hello Andrew - no I'm afraid that I didn't have any success with this at all Thanks Helen

AndrewIsh commented 7 years ago

Hi Helen

I see what you mean. I'll create an internal issue and investigate.

Many thanks Andrew

mrenvoize commented 7 years ago

I believe I have fixed the underlying issue here, but it needs some testing. Would you be willing to give it a go @hloliver ?

hloliver commented 7 years ago

Just tried testing this out but it's locked the hierarchy again (see #309) - can you unlock it asap as I'm working at home on RL2 today Thanks Helen

AndrewIsh commented 7 years ago

Hi Helen

Martin has now unlocked the hierarchy, apologies for the inconvenience.

Many thanks Andrew

hloliver commented 7 years ago

?Thanks!

Can you let me know when you think this is fixed and I'll go back to testing out the rollover

Helen

?

From: Andrew Isherwood notifications@github.com Sent: 21 February 2017 15:22 To: PTFS-Europe/rebus-list-2 Cc: Helen Oliver; Mention Subject: Re: [PTFS-Europe/rebus-list-2] Rollover doesn't seem to be working (#290)

Hi Helen

Martin has now unlocked the hierarchy, apologies for the inconvenience.

Many thanks Andrew

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PTFS-Europe/rebus-list-2/issues/290#issuecomment-281374895, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALotJ6DGw4535ZvKUeKq2WOIyVqcpamiks5rewErgaJpZM4LbzKA.

mrenvoize commented 7 years ago

This was already fixed, but the fix had not taken effect.

I've now made sure that fix is in effect and tested it on your system a couple of times. For your information, a clone of the 'Tavistock and Portman Library' tree locked the hierarchy an average of 1 minute and a subsequent 'Rollover (with archive)' on that cloned tree took an average of 5 minutes.

I took the above averages over three runs and during quiet times (i.e 7am this morning). When the system is busier these figures may creep up slightly.

I've reset your system to a state from before my testing this morning.

Martin

hloliver commented 7 years ago

Thanks Martin,

The fix for the locking problem seems to have definitely taken now, I've just tried it on a single list and it only took a few seconds.

However, selecting 'Rollover with archive' didn't create an archived version: https://www.screencast.com/t/aBzh5bBK

Helen

mrenvoize commented 7 years ago

Thanks Helen, I hadn't spotted that, I'll take a look imminently.

mrenvoize commented 7 years ago

This needs testing again, but I'm reasonably confident I've not been able to replicate this issue since early March.

hloliver commented 7 years ago

?Tested rollover with archive again this evening - just on 2 lists https://tavi.rebuslist.co.uk/#/list/2179 and https://tavi.rebuslist.co.uk/#/list/2182, but it's been over an hour now and I've still got the 'Hierarchy is locked whilst inheritance is recalculated?' message

can you unlock it

Thanks

Helen

hloliver commented 7 years ago

Thanks for unlocking - just to let you know that the rollover with archive didn't work, unless the archive copies ended up somewhere else and I haven't found them yet.