PTST / O365-HomeAssistant

Office 365 integration for Home Assistant
MIT License
69 stars 13 forks source link

Implement the Home Assistant CalendarEventDevice #44

Closed crazyfx1 closed 4 years ago

crazyfx1 commented 4 years ago

Is your feature request related to a problem? Please describe. The new overhaul of the integration is great and I can already receive the events. To use existing lovelace calendar cards, the calendar events have to be returned in a format which is the same for all home assistant calendars. Those are defined in the CalendarEventDevice ( https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/calendar/__init__.py)

I would assume that's also necessary for the component to be accepted as official hass component (but that's just my opinion).

It seems like all the methods are already existing in your component, they just need to be wired up and the event converted to the standard hass event format.

For implementation hints you could also check the caldav component: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/caldav/calendar.py

github-actions[bot] commented 4 years ago

Thank you for posting an issue, please make sure to note the following Installation method: (HACS|Manual) Any logs provided by home assistant if applicable

PTST commented 4 years ago

This has been implemented in 2.1.4

crazyfx1 commented 4 years ago

Thank you very much, it works just flawlessly, very good job!