PTST / O365-HomeAssistant

Office 365 integration for Home Assistant
MIT License
68 stars 13 forks source link

"Detected use of deprecated `base_url` property" log message #78

Open mdegat01 opened 4 years ago

mdegat01 commented 4 years ago

After start-up on 0.112 I saw this message in my logs:

Detected use of deprecated `base_url` property, use `homeassistant.helpers.network.get_url` method instead. Please report issue to the custom component author for o365 using this method at custom_components/o365/__init__.py, line 40: callback_url = f"{hass.config.api.base_url}{AUTH_CALLBACK_PATH}"

Reporting it as an issue as requested

mdegat01 commented 4 years ago

Oh was going to do a PR for this but it looks like you already fixed this on master. Will leave it open for now since other users will likely see this message and go here to report the same issue. But yea looks like as soon as the next version comes out the problem is resolved 👍