Open PThie opened 1 week ago
The assertion fails for HK in regional effects changes.
https://github.com/PThie/RWI-GEO-REDX/blob/44db2e264d398fe5941f0ce1bfe1144fff0d8262/src/test/testing_differences_region_effects_versions.R#L41C1-L68C8
Similar problem as for #50.
Overall question: Do the tests fail because there is more variation in the change values? Are the tests meaningful for the change values? Is the threshold meaningful for the change values? What should be done if the test fails?
The assertion fails for HK in regional effects changes.
https://github.com/PThie/RWI-GEO-REDX/blob/44db2e264d398fe5941f0ce1bfe1144fff0d8262/src/test/testing_differences_region_effects_versions.R#L41C1-L68C8
Similar problem as for #50.
Overall question: Do the tests fail because there is more variation in the change values? Are the tests meaningful for the change values? Is the threshold meaningful for the change values? What should be done if the test fails?