search

PTsolvers / JustRelax.jl

Pseudo-transient accelerated iterative solvers
https://ptsolvers.github.io/JustRelax.jl/dev/
MIT License
30 stars 5 forks source link

fixes 3D extension backend mixup #150

Closed aelligp closed 5 months ago

aelligp commented 5 months ago

This PR fixes some copy paste errors in the 3D extensions for both CUDA and AMDGPU

@albert-de-montserrat: Does AMDGPU need to be a deps in the Project.toml or can it also be moved to a weakdeps?

albert-de-montserrat commented 5 months ago

It should be a weakdep because its an extension

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/ext/AMDGPU/3D.jl 0.00% 14 Missing :warning:
src/ext/CUDA/3D.jl 0.00% 8 Missing :warning:
Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

luraess commented 5 months ago

It should be a weakdep because its an extension

Do we actually need it as weakdeps? Extension would not require it as weakdeps, unless you maybe want to control versions...

aelligp commented 5 months ago

Do we actually need it as weakdeps? Extension would not require it as weakdeps, unless you maybe want to control versions...

I guess so. This is from the Julia docs:

A package "extension" is a module that is automatically loaded when a specified set of other packages (its "extension dependencies") are loaded in the current Julia session. Extensions are defined under the [extensions] section in the project file. The extension dependencies of an extension are a subset of those packages listed under the [weakdeps] section of the project file. Those packages can have compat entries like other packages.

This also means that JustRelaxAMDGPUExt = "AMDGPU" needs to be under [extensions]