search

PTsolvers / JustRelax.jl

Pseudo-transient accelerated iterative solvers
https://ptsolvers.github.io/JustRelax.jl/dev/
MIT License
30 stars 5 forks source link

Compute local rank grid with `lazy_grid` #85

Closed albert-de-montserrat closed 10 months ago

boriskaus commented 10 months ago

lazy_grid and friends are routines that are useful also outside JustRelax. Would it make sense to put that in a different package (e.g., CompGrids)?

albert-de-montserrat commented 10 months ago

It would makes sense. What's the state of CompGrids? is it usable or needs a good update/rework?

boriskaus commented 10 months ago

it essentially contains nothing, so adding lazy_grid here as well as the CreateArrays function we discussed on Discord would be a great start. It would allow us to make GeophysicalModelGenerator compatible with ParallelStencil examples with rather minor changes.

albert-de-montserrat commented 10 months ago

Cool! Once I have everything fully figured out and tested in JR I will see how to move it out with a proper API. CompGrids can be a starting point.

boriskaus commented 10 months ago

Can heatdiffusion_PT! deal with nonlinearities caused by latent heat? If yes, it could fully replace the corresponding routine in MagmaThermoKinematics (with the advantage that JustRelax runs with MPI as well).

albert-de-montserrat commented 10 months ago

Not in the current state, but it should be just some extra lines of code. I will add it as soon as I can. Anything else needed for MTK?

On Tue, 2 Jan 2024, 16:44 Boris Kaus, @.***> wrote:

Can heatdiffusion_PT! deal with nonlinearities caused by latent heat? If yes, it could fully replace the corresponding routine in MagmaThermoKinematics (with the advantage that JustRelax runs with MPI as well).

— Reply to this email directly, view it on GitHub https://github.com/PTsolvers/JustRelax.jl/pull/85#issuecomment-1874193272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN23AHGVMOCMPBE2AAZNF4TYMQTN7AVCNFSM6AAAAABBFT5DPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGE4TGMRXGI . You are receiving this because you authored the thread.Message ID: @.***>