Closed Thibault34 closed 7 years ago
Can you fix failing tests?
Hello, can you help me please ? I don't understand, error is :
Argument 1 passed to FOS\UserBundle\Doctrine\UserManager::__construct() must be an instance of Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface, instance of Mock_PasswordUpdaterInterface_727bf80d given, called in /home/travis/build/PUGX/PUGXMultiUserBundle/Doctrine/UserManager.php on line 46 and defined
But, EncoderFactoryInterface is no longer in any new version.
You need to update tests to reflect changes you did in the code
I have update test. I don't understand because error is no on PHP 5.5 and more
The error on 5.3 is about memory, you can ignore it for now. Instead, the problem with 5.4 is tricky, because FOSUserBundle raised its requirements to php 5.5: so it happens that on php 5.4 we get the old version of FOSUserBundle, while on php 5.5 and newer we get the new version of FOSUserBundle. So, we need a solution that fits in both versions of FOSUserBundle, unless we also raise requirements.
Are you ok for raising requirements ?
I'm OK. Let's see what others think about it. Ping @leopro @giorrrgio @eux
I have update test. I don't understand because error is no on PHP 5.5 and more
Le 26/10/2016 à 09:20, Massimiliano Arione a écrit :
You need to update tests to reflect changes you did in the code
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PUGX/PUGXMultiUserBundle/pull/135#issuecomment-256268850, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLhjhU3a9d7jH8O-Nzrp1Z_Y1VeMl2Vks5q3v9OgaJpZM4KgGcV.
You should also update .travis.yml
and remove 5.3 and 5.4 builds
No problem now :)