search

PUGX / badge-poser

The PHP badges, renders some badges for your readme with the packagist information.
https://poser.pugx.org
MIT License
475 stars 93 forks source link

Flat icons support #143

Closed dimsav closed 9 years ago

dimsav commented 9 years ago

I don't see anywhere the support for flat icons. Is this feature already implemented or coming anytime soon?

Thanks!

liuggio commented 9 years ago

This is a good idea

fefas commented 9 years ago

+1

ramsey commented 9 years ago

+1

liuggio commented 9 years ago

anyone want to do this?

ramsey commented 9 years ago

I thought about taking a look myself to implement, but I'm not sure how to get badge-poser running locally to implement and test.

I notice that Shields has the ability to add ?style=flat to the end of the URL to generate flat vs. "plastic" style of badge. I'm not familiar with Buckler (which is what it appears you're using here), but if it follows the Shields standard, then perhaps it's a simple addition to allow users to append ?style=flat and then pass that through to Buckler?

Flat badge Plastic badge

![Flat badge](https://img.shields.io/badge/style-flat-green.svg?style=flat)
![Plastic badge](https://img.shields.io/badge/style-flat-green.svg?style=plastic)
liuggio commented 9 years ago

Hi this is a symfony2 project and doesn't use buckler if you want to run this project the readme https://github.com/PUGX/badge-poser#contribution could help you,

BUT

I think the first step is working at this library https://github.com/badges/poser
then add a new SvgRender called FlatSvgRender or something like that (https://github.com/badges/poser/blob/master/src/Render/SvgRender.php#L29) you should also add some test, when this is fixed the symfony project is the next step.

ramsey commented 9 years ago

I'm not sure what the difference is in the projects.

I saw here (#106) that it appears you're using Buckler, which is why I thought you were using Buckler. Sorry for the misunderstanding.

liuggio commented 9 years ago

No problem we have decoupled a library from the website the library is here https://github.com/badges/poser We have used bucker but we decided to put it off...

liuggio commented 9 years ago

tadaaaaaa https://github.com/badges/poser/pull/3/files first step is done