PUNCH-Cyber / YaraGuardian

Django web interface for managing Yara rules
Apache License 2.0
190 stars 43 forks source link

Plyara version changes #57

Open Taskr opened 5 years ago

Taskr commented 5 years ago

Newer versions of plyara have different output and semantics - will need to adjust YaraGuardian accordingly.

halos commented 5 years ago

Since plyara version 2, metadata field in parsed rules changed from a dict to a list of dicts. You can see 'complaints' about this in this issue: https://github.com/plyara/plyara/issues/52

It would be easier if you force or recommend to use some specific version. Last plyara version that returns a dict is 1.4.1.

This would be helpful too with the Django version, as some views name were refactored: https://github.com/PUNCH-Cyber/YaraGuardian/blob/c09d8f054aa12357a61ea9caf41b5cf5b62fc727/YaraGuardian/urls.py#L45 and https://github.com/PUNCH-Cyber/YaraGuardian/blob/c09d8f054aa12357a61ea9caf41b5cf5b62fc727/YaraGuardian/urls.py#L49

django version 2.0 is the last version that uses the same view names as you.