PUNCH-Cyber / stoq-plugins-public

stoQ Public Plugins
https://stoq.punchcyber.com
Apache License 2.0
72 stars 24 forks source link

Added stoq plugin for submitting to acce (#1) #133

Closed rhartig-ct closed 2 years ago

rhartig-ct commented 2 years ago
dvanbrug commented 2 years ago

Hi @rhartig-ct, thanks for the PR! I am not familiar with the ACCE tool and didn't see a way to setup a test instance so I'm not sure I could run a full test on this. From looking through the code it looks pretty straight forward though.

Since you're from Cipher Tech Solutions, would you be willing to be the POC for any issues / PRs that come up in the future for this plugin? If so, maybe you could update the README as part of the plugin folder to indicate you're the POC (or someone else you designate) so we know who to reach out to if anything comes up?

rhartig-ct commented 2 years ago

Thanks for reviewing this @dvanbrug Currently ACCE is offered only as a paid service, but we are working towards a free version that would be available to all. We will maintain this plugin, just needed you to check that everything is done the 'stoq' way. I was unsure what t do about the licenses/copyright, so I just copied from other plugins. They all seem to reference PUNCH so ours does to, please advise if that should be changed.

As per your suggestion I've added a support email that can be used to any issues related to the ACCE plugin.

dvanbrug commented 2 years ago

@rhartig-ct Ok looks good. As far as the licenses/copyright goes that is a good question. I think it is fine to leave it as is, however if you'd rather change the notice to reference Cipher Tech Solutions I can double check with our legal team to verify what needs to happen w.r.t. our open source processes.

Just let me know how you'd like to proceed and we can get this merged in.

rhartig-ct commented 2 years ago

@dvanbrug Our legal seems fine as is, so we can go ahead and move forward.

dvanbrug commented 2 years ago

@rhartig-ct Sounds good. Thanks again for the contribution!