search

PUP-BSIT / ex7-digital_dynasty

ex7-digital_dynasty created by GitHub Classroom
0 stars 0 forks source link

Issue Title: Score & Feedback #20

Open ssvillarosa opened 4 months ago

ssvillarosa commented 4 months ago

@bergado-shamma - Next time, place all your images into one folder so it won't clutter your project directory. Added it to the coding guidelines. https://docs.google.com/presentation/d/1iCoz17mBxZtIQ9PifAW0jjKsuv4xDTlx-TPQxdLySow/edit#slide=id.g26e9a7bd30a_1_0

@Morcoso-daisy -ex7-submissions\ex7-digital_dynasty\merge_editor\Morcoso_Daisy.png this is not a valid merge editor screenshot. kindly read my instructions carefully.

Your reviewer told you to move the styles into the css. Why didn't you follow?

https://github.com/PUP-BSIT/ex7-digital_dynasty/issues/11#issuecomment-2044700918

Another issue you did not fix.

https://github.com/PUP-BSIT/ex7-digital_dynasty/issues/11#issuecomment-2044697228

Score 7/10

bergado-shamma commented 4 months ago

Okay po, thank you po

REYESJOHNRUIZ commented 4 months ago

thank you sir

norona-marynicole commented 4 months ago

Thank you po, sir.