PUP-BSIT / exercise-13-tuf_developers

exercise-13-tuf_developers created by GitHub Classroom
0 stars 0 forks source link

Add Changes to Files #3

Closed Donatos-Andrea closed 1 month ago

Donatos-Andrea commented 1 month ago

edit javascript file - f436422b92e04c3ffc6d7971c1a9f48fdaac621f. edit the button type in html - eeb19088a8f9e555cc3c184fc4a86c165b126283. edit html file - 70a2d9b235ca48ab8bebf6ebe014fb2577598ca9. edit js file - 39bf6073db1f9791b802bf13481d4662a21dcd12.

Monroy-JeffCarl commented 1 month ago

Hello, Andrea! I am Jeff and I am tasked to review your codes. Thank you!

Monroy-JeffCarl commented 1 month ago

Also, make sure that the newly added comments are sorted correctly alongside hard-coded ones.

Donatos-Andrea commented 1 month ago

Also, make sure that the newly added comments are sorted correctly alongside hard-coded ones.

hello po, hindi ko po masyado magets mga need ko mabago sana po palink ng mismong need ng changes. thank youuu

Monroy-JeffCarl commented 1 month ago

Hello! Apologies sa confusion. Sa end ko, ganito yung behavior ng comment section. And based sa step no. 4 sa exercise 13, the comments should be sortable by date. Thank you! Screenshot 2024-05-15 234448

https://github.com/PUP-BSIT/exercise-13-tuf_developers/assets/146610699/5f6e6861-0105-4cbe-8676-0433fc8cebd6

Monroy-JeffCarl commented 1 month ago

But overall, your code looks good and the UI is impressive! Thank you again, Andrea!

netlify[bot] commented 1 month ago

Deploy Preview for cahigan-marklouie ready!

Name Link
Latest commit 686843ea98dd826b612d91d655e295cbe8310ee0
Latest deploy log https://app.netlify.com/sites/cahigan-marklouie/deploys/6644dbae8586490008af21b5
Deploy Preview https://deploy-preview-3--cahigan-marklouie.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Donatos-Andrea commented 1 month ago

But overall, your code looks good and the UI is impressive! Thank you again, Andrea!

fix date sorting bug - 686843ea98dd826b612d91d655e295cbe8310ee0

thank you po