PUP-BSIT / exercise-14-sixth_sense

exercise-14-sixth_sense created by GitHub Classroom
0 stars 0 forks source link

Sixth Sense – Exercise 14 Feedback #16

Open Martinez-Emmanuel opened 1 month ago

Martinez-Emmanuel commented 1 month ago

Mr. Trinidad's work for this week's exercise is generally commendable and mostly adheres to our coding guidelines.

There is still room for code improvements, particularly in fetching the countries in script.js but overall, this was great work.

Casabuena-AngelRose commented 1 month ago

Mr. Escuro's & Ms. Ardemilla's work for this week's exercise is overall good.

The errors in their code are the ones that are simple, and I'm not judging them because what might be simple for me might not be for them. But sometimes in life, even in code, it's the simple things that get forgotten. But still, a job well done!

nabayra-james commented 1 month ago

Mr. Ilagan's work for this week's exercise is commendable but still requires some improvement.

The Country Search Feature requires additional time to fully fetch the data. I believe there are improvements needed in script.js to optimize this process. Additionally, the placement of the country button should be adjusted in the right place where it should be or just align it with the sample works. Overall, the work demonstrates significant effort and quality.

Dupo-JudyAnn commented 1 month ago

Mr. Gasta's work on this week's exercise is good, though there are some parts of his code that I believe he will improve further.

• Communicates well with the reviewer. • When requested for changes, the response and corrections were quickly provided. • The Country Search feature is working fine.

Danay-MaryJoy commented 1 month ago

Ms. Rosario's work for exercise 14 is quite good, only minor adjustments to align in coding guidelines had been done during PR.

Overall, initial pitfalls in her code during PR is understandable, she adjusted her work quickly to fix them. Additionally, the search feature in country took time to fetch, might need some improvement in her country.js file.

ssvillarosa commented 1 month ago

Score: ARMEDILLA - 9 ESCURO - 9 GASTA - 9 ILAGAN - 8 ROSARIO - 10 TRINIDAD - 9