PWhiddy / PokemonRedExperiments

Playing Pokemon Red with Reinforcement Learning
MIT License
7k stars 645 forks source link

With truncate progress bar instead of overflow error update #115

Closed techmore closed 1 year ago

techmore commented 1 year ago

I get an error now from a clean install

/PokemonRedExperiments/baselines/red_gym_env.py", line 355, in make_reward_channel memoryLcol, rowl = last_pixel * (255 // col_steps) IndexError: index 39 is out of bounds for axis 0 with size

If I add
if 0 <= col < memory.shape[0] and 0 <= row < memory.shape[1]: memory[:col, row] = 255 col_covered = col col_steps last_pixel = floor(r_val - row_covered - col_covered) memory[col, row] = last_pixel (255 // col_steps) else: print(f"col or row out of bounds: col={col}, row={row}") return memory

It runs but I get this popping up

col or row out of bounds: col=39, row=7

PWhiddy commented 1 year ago

Looks like issue #116 was a dupe of this, so also should be fixed by 0ce7fff2264d5d8c2b78e314705a89843b57a1b0

techmore commented 1 year ago

Can confirm clean install with this patch https://github.com/PWhiddy/PokemonRedExperiments/issues/116 resolves it.

Thank you!