PWhiddy / PokemonRedExperiments

Playing Pokemon Red with Reinforcement Learning
MIT License
7.02k stars 645 forks source link

Menu.py mod Adds resume from .zip, send and receive zips #118

Open techmore opened 1 year ago

techmore commented 1 year ago

These patches add a menu.py that displays local checkpoints and downloaded checkpoints. This does not affect any local files and offers them as default runs.

3 locations are added

The main issue I see now is training / saving times are so long you need to watch and wait for a .zip to come up before you cancel out and lose a ton of training.

Screenshot 2023-10-24 at 6 36 16 PM Screenshot 2023-10-24 at 6 28 35 PM
PWhiddy commented 1 year ago

Hey, looks cool! This has quite a bit of new code which I can't review/test very thoroughly right now, but it looks like it operates pretty independently from the existing code? I'd be happy to merge this if you're willing to take responsibility for maintaining and handling any issues related to this feature!

techmore commented 1 year ago

Hey that sounds great. Yes the current code does not affect any of your existing files but it does run and create files new folders.

Rather than immediately merge it to main would you consider doing a menu branch so it's easy to access but those people know to expect functionality change and we get some feedback. I would really like some "guidance" in context of your preferences for listing run_ file to be displayed as the 99, 98, 97 options to make that front and center?

A branch could give some time for those questions to settle and see how it's received

In the meantime I'll confuse on optimization and documentation before a merge to main.

S3mz commented 1 year ago

wha this looks great @techmore.

I didn't have the time to dedicate to this project last couple of days but i see @PWhiddy is thinking about merging it with the master. That would be awesome.

I'll try to try it out myself in the meantime. Talk to you soon