search

PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.47k stars 13.5k forks source link

review RC parsing and NuttX parity bit #10939

Open dagar opened 5 years ago

dagar commented 5 years ago

SBUS uses an even parity bit. Is it actually being used with current NuttX?

dagar commented 5 years ago

@davids5 what was the conclusion here?

davids5 commented 5 years ago

It is configured in the correct mode IIRC the error is not propagated nor that chatrater dropped. The issues that shed light on this was a mis configuration. There is some "Framing" in the decoder that may detect a problem or not. Are there any open issues that indicate SBUS related problems?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

junwoo091400 commented 2 years ago

Is this still an issue?

davids5 commented 2 years ago

There is a PR in to test a fix https://github.com/PX4/PX4-Autopilot/pull/19446 but I am not sure if the testing that has been done is testing the right things or reporting the right problems.