Closed mrpollo closed 5 years ago
@dagar this is the output of the changelog generator tool, let me know if there's anything missing
I'm not sure about how useful that is and what is enhancements vs PRs. The fact that it misses that we implemented Collision Prevention and Obstacle avoidance in missions is a worry.
Hey @hamishwillee this is the output of a tool we use to generate the complete changelog, we are also adding a summary section and possibly a migration guide if there's anything that needs documenting, here's an example of v1.8.0 release notes, the purpose of this issue is to find missing changes, we need to adjust the tool to find everything between v1.8.3 and v1.9.0.
About the labels, I think we are definitely not consistently labeling issues for this to be more useful, here are the basic guidelines we are trying to follow on our changelog, and lastly here's how the breakdown is done via labels from the tool readme.
@hamishwillee can you point me to the PRs it missed with Collision Prevention and Obstacle avoidance?
@mrpollo It might not have missed them, just put them in wrong place - and the PR titles don't really capture the significance of particular features. #10785 is collision prevention. Not sure about obstacle avoidance.
Edited: OK, just saw I missed your first response and only saw the note immediately above. Sure, if this is just a starting point ignore me :-)
this one seems significant: https://github.com/PX4/Firmware/pull/10738
What about changes in the ecl
? I feel that is a pretty important part of the change log
@dakejahl ECL is platform independent.
@dakejahl @TSC21 If the ECL submodule was updated it should be reflected here in some way and we can link to the ECL project for details on the update, same for every other submodule, thanks for bringing this up.
@hamishwillee I totally see where you are coming from here, I'm with you on this one changelog != release notes
.
Great Work!
Just pushed an update!
@dagar , change log is updated now, we need to distill this into high level release note.
@mrpollo @MaEtUgR Is orbit mode going in? https://github.com/PX4/Firmware/pull/10907
I don't know if this is valid for this this log, but a big reason I need this update is for the lidarlite v3hp functionality - it didn't work in 1.8.2
@hamishwillee Orbit is in and QGC also supports the command since last release. Good catch, I don't know where it got lost.
That's a great catch @hamishwillee
Everyone, please help us review the changelog for any missing features, we should be as accurate as possible.
@mrpollo You are planning on creating a high level overview part to these notes right - in line with https://discuss.px4.io/t/what-to-expect-from-1-9-release/11117/3 ?
Team Work :tada:
Getting ready for v1.9.0 it's time to put together the list of changes that went into the making of v1.9.0 (more changes are still coming in the next few days), this post is meant for discussion on what goes into the release notes and the summary section of the release notes.
STATUS: Work In Progress, some PRs/Issues are missing. :warning: :warning: :warning:
READ BELOW
:arrow_down: :arrow_down: :arrow_down:
Release notes
WIP
Change Log
Changelog
v1.9.0 (2019-04-10)
Full Changelog
Implemented enhancements:
Fixed bugs:
Closed issues:
hrt\_elapsed\_time
call with a non-atomic call #11245Merged pull requests:
\_hil\_frames
and\_old\_timestamp
member vars and dead logic from MavlinkReceiver class - (Break apart PR#11274 into easily verifiable steps - Step 6) #11612 (mcsauder)\#includes
from mavlink_main.cpp and relocate two\#defines
to mavlink_main.h #11580 (mcsauder)* _This Changelog was automatically generated by github_changelog_generator_