Feedforward parameter bound check

[ktskt]

Describe the bug Dear, developers. I appreciate your great work.

During the tests, I think there is a loose parameter check in feedforward parameters. Personally, I think unbounded feedforward parameters (e.g., MC_PITCHRATE_FF, MC_ROLLRATE_FF, MC_YAWRATE_FF) definitely cause bad flight performance or even crash. In addition, they show bad performance even with small values (e.g., 1.0) Please note that default is 0.0.

I am talking about not only range check (in program) but also documented ranges in https://dev.px4.io/en/advanced/parameter_reference.html Even if their values can be changed according to the model or specs, such parameters should be bounded. Otherwise, some people who don't know the meaning of parameters may put strange values due to a lack of a minimal guidance....

Such parameters can be modified whenever PX4 runs via GCS command.

To Reproduce With GCS connected to a drone, send param set MC_PITCHRATE_FF or MC_ROLLRATE_FF or MC_YAWRATE_FF with some values (e.g., 10 , 5 )

Expected behavior It can crash or show oscillating flight patterns...

Log Files and Screenshots If you need it, I will prepare it. But, it is very easy to reproduce....

Drone (please complete the following information): SITL with IRIS+ quadcopter model

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

Closing as stale.

[julianoes]

We would appreciate a pull request!

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

[junwoo091400]

😢