PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.53k stars 13.52k forks source link

Position Control does not auto re-engage when using Joystick #13348

Open nicovanduijn opened 5 years ago

nicovanduijn commented 5 years ago

Describe the bug If there is a fallback to Altitude mode from Position, the vehicle cannot recover back to position mode (once available) if it is commanded via MAVLink (instead of RC).

To Reproduce Steps to reproduce the behavior:

  1. Get a GPS-only drone and set it up to fly via MAVLink (e.g. Tablet + Joystick)
  2. Fly in position control
  3. Start a mavlink shell and type "gps stop", the vehicle will go into altitude mode
  4. Type "GPS start -b 115200" in the mavlink shell
  5. You can wait all you want, the drone will remain in Altitude mode

Expected behavior The drone should re-engage position control once the estimate becomes valid again.

Log Files and Screenshots https://review.px4.io/plot_app?log=06b6f16a-de9b-4806-bd77-8fc86324e339

bokeh_plot

We can see that the position estimate re-appears when the GPS kicks back in, but the mode does not switch. bokeh_plot (1)

Drone (please complete the following information):

MaEtUgR commented 4 years ago

Related: https://github.com/PX4/Firmware/issues/12688

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.