search

PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.26k stars 13.41k forks source link

Non-existing package in Arch setup script #17797

Open Northo opened 3 years ago

Northo commented 3 years ago

Describe the bug The Arch setup script PX4-Autopilot/Tools/setup/arch.sh attempts to install yay from the default repositories. That package does not, however, exist (it is only in AUR). Since the package is not found, none of the other packages are installed either, and also the setup script does not terminate, but carries on without the packages installed.

This is confusing, as it is difficult for the user to understand what failed - especially if yay is already installed, in which case the gazebo is installed as expected.

To Reproduce Steps to reproduce the behavior:

  1. Run the installation script on an Arch system

Expected behavior All needed packages should be installed, and the script should terminate or be more verbose on failure.

Suggested solution Remove yay from the package list given to pacman - either require the user to manually install yay, install gazebo from AUR with the script (not using yay), or something else. Also, improve the verbosity or crash-on-failure behaviour.

Northo commented 3 years ago

I am new to PX4, and I am not familiar with the contribution procedures. However, I will gladly submit a PR if that is OK.